Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario visualization loading improvements - part 1 - FE changes #7515

Merged
merged 10 commits into from
Feb 10, 2025

Conversation

mgoworko
Copy link
Contributor

@mgoworko mgoworko commented Jan 30, 2025

Describe your changes

Improved scenario loading time. On real-world example, this change together with other parts of the task managed to reduce loading time by 40-50%.

Changes:

  • The scenario graph rendering starts as soon as possible. There is an addition API call at the very beginning. The graph is first fetched without validation, which is very quick. And the rendering starts immediately
  • The "tips" and "creator panel" are no longer waiting for the graph to load. They are shown immediately, and their content is added as soon as is possible.

Firefox profiling results on a sample, quite huge scenario:
(profiling started when user sees list of scenarios, then clicks on one of them the chosen scenario is loaded)

  • before
    before

  • after
    after

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe docs ui labels Jan 30, 2025
@Dzuming Dzuming self-requested a review January 31, 2025 09:51
designer/client/cypress/support/process.ts Outdated Show resolved Hide resolved
designer/client/src/actions/nk/process.ts Outdated Show resolved Hide resolved
designer/client/src/common/ProcessUtils.ts Show resolved Hide resolved
designer/client/src/common/ProcessUtils.ts Outdated Show resolved Hide resolved
designer/client/src/reducers/selectors/graph.ts Outdated Show resolved Hide resolved
designer/client/src/components/tips/ValidTips.tsx Outdated Show resolved Hide resolved
@mgoworko mgoworko requested a review from Dzuming February 7, 2025 16:52
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgoworko mgoworko merged commit 4a7ab57 into staging Feb 10, 2025
14 checks passed
@mgoworko mgoworko deleted the improve-scenario-loading-time-part-1-fe-changes branch February 10, 2025 09:14
mgoworko added a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe docs ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants