-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenario visualization loading improvements - part 1 - FE changes #7515
Merged
mgoworko
merged 10 commits into
staging
from
improve-scenario-loading-time-part-1-fe-changes
Feb 10, 2025
Merged
Scenario visualization loading improvements - part 1 - FE changes #7515
mgoworko
merged 10 commits into
staging
from
improve-scenario-loading-time-part-1-fe-changes
Feb 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oading-time-part-1-fe-changes # Conflicts: # docs/Changelog.md
Dzuming
requested changes
Feb 7, 2025
Co-authored-by: Dawid Poliszak <[email protected]>
Co-authored-by: Dawid Poliszak <[email protected]>
…oading-time-part-1-fe-changes
Dzuming
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mgoworko
added a commit
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Improved scenario loading time. On real-world example, this change together with other parts of the task managed to reduce loading time by 40-50%.
Changes:
Firefox profiling results on a sample, quite huge scenario:
(profiling started when user sees list of scenarios, then clicks on one of them the chosen scenario is loaded)
before
![before](https://private-user-images.githubusercontent.com/37329559/408175620-377965d1-7b0e-42ee-a1c0-0eaa5e62b642.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDA5OTcsIm5iZiI6MTczOTQwMDY5NywicGF0aCI6Ii8zNzMyOTU1OS80MDgxNzU2MjAtMzc3OTY1ZDEtN2IwZS00MmVlLWExYzAtMGVhYTVlNjJiNjQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTEzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3OWI5YjQ1NzIyZjhjM2UwYTkyYjg3Y2VmYjMwNjg2MjhhODBhNTcxZTBjMGU2ZTAzY2RhMDg4YjliYTQ4NjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xAg44SLzpKv3ihpCCGa-TSykPHMBKAv4uhIGDdzaUWg)
after
![after](https://private-user-images.githubusercontent.com/37329559/408175661-0704c08a-9dba-42eb-86e5-989d36494d84.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDA5OTcsIm5iZiI6MTczOTQwMDY5NywicGF0aCI6Ii8zNzMyOTU1OS80MDgxNzU2NjEtMDcwNGMwOGEtOWRiYS00MmViLTg2ZTUtOTg5ZDM2NDk0ZDg0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTEzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVlODUwY2E4Njc4YzMxMDE1YWM3YjJiNGM1MmJmOGMwNGYzNTkwYjQxNDE2YTgxNjY0M2FiY2MyM2U5OWQxMGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mcGetbWtkGPjK3QZOuTGMHSbrPlhzqM_kPzhMjukeZ4)
Checklist before merge